Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[barefoot] Switch to Y profiles for Newport board #5187

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

vboykox
Copy link
Member

@vboykox vboykox commented Aug 14, 2020

Signed-off-by: Volodymyr Boyko [email protected]

- Why I did it
To make the newport platform choose the Y1 profile on startup.

- How I did it

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

@vboykox
Copy link
Member Author

vboykox commented Aug 14, 2020

@akokhan @msosyak

@vboykox vboykox force-pushed the newport_select_y1 branch from f79abbc to b50ffb1 Compare August 14, 2020 12:50
@vboykox vboykox changed the title [barefoot] Switch to Y profiles for Newport board WIP: [barefoot] Switch to Y profiles for Newport board Aug 14, 2020
@vboykox vboykox force-pushed the newport_select_y1 branch 2 times, most recently from f6d43c4 to c179854 Compare August 14, 2020 14:25
@vboykox vboykox changed the title WIP: [barefoot] Switch to Y profiles for Newport board [barefoot] Switch to Y profiles for Newport board Aug 14, 2020
@vboykox
Copy link
Member Author

vboykox commented Aug 14, 2020

please cherry-pick to 201911 and 202006

@vboykox
Copy link
Member Author

vboykox commented Aug 14, 2020

@jleveque

Copy link
Contributor

@akokhan akokhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should not override P4 profile config defined through config_syncd_barefoot()
Please add P4_PROFILE=$(sonic-cfggen -d -v 'DEVICE_METADATA["localhost"]["p4_profile"]') check

@vboykox vboykox force-pushed the newport_select_y1 branch from c179854 to 1c7ca27 Compare August 16, 2020 16:35
akokhan
akokhan previously approved these changes Aug 16, 2020
@akokhan
Copy link
Contributor

akokhan commented Aug 20, 2020

@jleveque , @lguohan , please approve and merge this. The motivation behind - Tofino2 based boards must use Y[n] profiles

@vboykox
Copy link
Member Author

vboykox commented Aug 28, 2020

@jleveque , @lguohan

@akokhan
Copy link
Contributor

akokhan commented Aug 31, 2020

@lguohan, please approve and merge

@akokhan
Copy link
Contributor

akokhan commented Sep 6, 2020

@lguohan , please approve and merge

@vboykox
Copy link
Member Author

vboykox commented Sep 22, 2020

@lguohan

@vboykox
Copy link
Member Author

vboykox commented Sep 23, 2020

@jleveque

@vboykox
Copy link
Member Author

vboykox commented Sep 23, 2020

@vboykox
Copy link
Member Author

vboykox commented Oct 1, 2020

@lguohan

@akokhan
Copy link
Contributor

akokhan commented Oct 2, 2020

@lguohan , is there anything that blocks us from merging this? Could you please take a look? Thank you.

@vboykox
Copy link
Member Author

vboykox commented Oct 7, 2020

@jleveque @lguohan

1 similar comment
@vboykox
Copy link
Member Author

vboykox commented Oct 7, 2020

@jleveque @lguohan

@lguohan lguohan merged commit 9a1f68b into sonic-net:master Oct 8, 2020
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants